Add default value for gem provider in report class

Author: remicalixte

manifests/init.pp

@@ -231,7 +231,7 @@
   $facts_to_tags = [],
   $puppet_run_reports = false,
   $puppetmaster_user = $settings::user,
-  $puppet_gem_provider = $datadog_agent::params::gem_provider,
+  String $puppet_gem_provider = $datadog_agent::params::gem_provider,
   $non_local_traffic = false,
   $dogstreams = [],
   $log_level = 'info',
@@ -335,7 +335,6 @@
   validate_legacy(Array, 'validate_array', $facts_to_tags)
   validate_legacy(Boolean, 'validate_bool', $puppet_run_reports)
   validate_legacy(String, 'validate_string', $puppetmaster_user)
-  validate_legacy(String, 'validate_string', $puppet_gem_provider)
   validate_legacy(Boolean, 'validate_bool', $non_local_traffic)
   validate_legacy(Boolean, 'validate_bool', $log_to_syslog)
   validate_legacy(Boolean, 'validate_bool', $manage_repo)

manifests/reports.pp

@@ -15,11 +15,11 @@
 #
 class datadog_agent::reports(
   $api_key,
-  $puppet_gem_provider,
   $puppetmaster_user,
   $dogapi_version,
   $hostname_extraction_regex = undef,
   $datadog_site = 'datadoghq.com',
+  $puppet_gem_provider = $datadog_agent::params::gem_provider,
 ) {
 
   include datadog_agent