[puppet] PE and POSS require puppetserver_gem to get the dogapi gem in the JRuby env.#188
Merged
[puppet] PE and POSS require puppetserver_gem to get the dogapi gem in the JRuby env.#188
Conversation
798f95f to
0cc4a84
Compare
Member
Author
|
Tested manually - successfully. |
Member
|
Nice, you can remove the comment about |
0cc4a84 to
8153350
Compare
…m in the JRuby env. [reporting] updating README.
8153350 to
bbb2ad1
Compare
…m in the JRuby env. [reporting] updating README. [reporting] puppet DSL doesn't allow reassignment, use new var.
…tadog-agent into jaime/fix_reporting_pe
cegeka-jenkins
pushed a commit
to cegeka/puppet-datadog_agent
that referenced
this pull request
Jan 31, 2018
[puppet] PE and POSS require puppetserver_gem to get the dogapi gem in the JRuby env.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
As it turns out PE and POSS have the puppetserver sit on top of their own JRuby environment, with its own set of gems, etc. Fortunately the
puppetserver_gemprovider comes to the rescue to allow us to provide the requireddogapigem (if you want reporting enabled) into the environment.