Support generic postgres custom metrics by sethcleveland · Pull Request #224 · DataDog/puppet-datadog-agent

sethcleveland · 2016-08-15T23:05:35Z

No description provided.

sethcleveland · 2016-08-15T23:06:00Z

Dropping in puppet support for the following -- https://help.datadoghq.com/hc/en-us/articles/208385813-Postgres-custom-metric-collection-explained

truthbk · 2016-08-17T15:14:04Z

+#   $custom_metrics
+#       An array of custom metrics with the following hash keys - query, metrics,
+#       relation, descriptors. Refer to this guide for details on those fields:
+#       https://help.datadoghq.com/hc/en-us/articles/208385813-Postgres-custom-metric-collection-explained


Could you please add an example with custom metrics below? Should help a bit with usability.

truthbk · 2016-08-17T15:15:33Z

Thanks a lot @sethcleveland, tackles an open issue which is always greatly appreciated! If you could add some spec tests that'd be fabulous.

sethcleveland · 2016-08-22T15:32:32Z

Sure thing. This is an open issue for us as well. I'll add documentation and spec tests.

sethcleveland · 2016-08-31T18:33:30Z

I did a brief scan on the failures and most things appear to fail this. --

bundle exec rake test
---> syntax:manifests
---> syntax:templates
---> syntax:hiera:yaml
manifests/integrations/mysql.pp:41:parameter_order:WARNING:optional parameter listed before required parameter
manifests/integrations/pgbouncer.pp:31:parameter_order:WARNING:optional parameter listed before required parameter
manifests/integrations/postgres.pp:56:parameter_order:WARNING:optional parameter listed before required parameter

I didn't make those changes. As far as I can tell they are the status quo.

sethcleveland · 2016-08-31T18:34:48Z

@truthbk: How are these changes?

truthbk · 2016-09-06T17:29:51Z

@sethcleveland this is great, thanks a lot. I'll review in a little bit more depth before merging, but it looks good. I'll keep you posted! I need to understand where those failures are coming from. Maybe if you rebase to the latest master we can get rid of them..... :)

- Adding resource definition for postgres custom metrics (for validation) - Added custom metrics example and test specs

sethcleveland · 2016-09-09T17:03:28Z

@truthbk just rebased against master. Hopefully that fixes the problems.

…s failing builds

sethcleveland · 2016-09-09T17:21:59Z

@truthbk turns out rebasing against master didn't resolve the failures. I'm assuming the linters were added after the fact. I fixed the failing builds as part of this PR commit -- 5cd38a4.

FWIW's I'm not clear why parameter optional/non-optional parameter ordering matters. I've only see puppet modules used with explicit parameter values.

rooprob · 2016-09-12T09:07:19Z

Hi,

Can we split out and merge 5cd38a4 as it's blocking PRs such as #231 and #229.

sethcleveland · 2016-09-12T15:23:43Z

@truthbk do these changes work? Other people can be unblocked by one of the commits. I can cherry pick the fix out into another PR while you spend more time reviewing these changes. Let me know where you'll stand before I make another PR.

sethcleveland · 2016-09-12T21:40:45Z

@rooprob I cherry-picked that commit and made a PR here -- #232.

mcasper · 2016-09-16T21:01:19Z

+#   $tags
+#       Optional array of tags
+#   $custom_metrics
+#       An array of custom metrics with the following hash keys - query, metrics,


Isn't this a hash of custom metrics?

Yup. I'll make an adjustment.

truthbk · 2016-09-20T14:42:35Z

@sethcleveland thank you so much for this and #232 - merging this in. Again, apologies for the long MTTR.

…tgres_custom_metrics Support generic postgres custom metrics

This was referenced Aug 16, 2016

Add postgres custom metrics #78

Closed

datadog_agent::integrations::postgres should support custom metrics #225

Closed

truthbk reviewed Aug 17, 2016
View reviewed changes

sethcleveland force-pushed the Support_generic_postgres_custom_metrics branch from 15108ed to fc575c1 Compare August 31, 2016 18:00

Support generic postgres custom metrics

411488d

- Adding resource definition for postgres custom metrics (for validation) - Added custom metrics example and test specs

sethcleveland force-pushed the Support_generic_postgres_custom_metrics branch from 4374d8a to 411488d Compare September 9, 2016 17:02

swapped order of optional vs. non-optional class parameters to addres…

5cd38a4

…s failing builds

rooprob mentioned this pull request Sep 12, 2016

Use HTTPS protocol, not Git, in .fixtures.yml #229

Closed

mcasper reviewed Sep 16, 2016

View reviewed changes

correcting custom_metrics documentation

efd2531

truthbk merged commit 8218721 into DataDog:master Sep 20, 2016

cegeka-jenkins pushed a commit to cegeka/puppet-datadog_agent that referenced this pull request Jan 31, 2018

Merge pull request DataDog#224 from sethcleveland/Support_generic_pos…

abffbda

…tgres_custom_metrics Support generic postgres custom metrics

Conversation

sethcleveland commented Aug 15, 2016

Uh oh!

sethcleveland commented Aug 15, 2016

Uh oh!

truthbk Aug 17, 2016

Choose a reason for hiding this comment

Uh oh!

truthbk commented Aug 17, 2016

Uh oh!

sethcleveland commented Aug 22, 2016

Uh oh!

sethcleveland commented Aug 31, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sethcleveland commented Aug 31, 2016

Uh oh!

truthbk commented Sep 6, 2016

Uh oh!

sethcleveland commented Sep 9, 2016

Uh oh!

sethcleveland commented Sep 9, 2016

Uh oh!

rooprob commented Sep 12, 2016

Uh oh!

sethcleveland commented Sep 12, 2016

Uh oh!

sethcleveland commented Sep 12, 2016

Uh oh!

mcasper Sep 16, 2016

Choose a reason for hiding this comment

Uh oh!

sethcleveland Sep 19, 2016

Choose a reason for hiding this comment

Uh oh!

truthbk commented Sep 20, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

sethcleveland commented Aug 31, 2016 •

edited

Loading