Skip to content

Add additional rabbitmq parameters in rabbitmq.yaml.example#288

Merged
truthbk merged 2 commits intoDataDog:masterfrom
alvin-huang:add_rabbitmq_params
Mar 3, 2017
Merged

Add additional rabbitmq parameters in rabbitmq.yaml.example#288
truthbk merged 2 commits intoDataDog:masterfrom
alvin-huang:add_rabbitmq_params

Conversation

@alvin-huang
Copy link
Copy Markdown
Contributor

@alvin-huang alvin-huang commented Dec 24, 2016

In the Datadog integration examples, the RabbitMQ one (https://github.com/DataDog/dd-agent/blob/master/conf.d/rabbitmq.yaml.example) had some additional parameters not currently available in the Puppet module.

This PR covers a couple different changes:

  1. Adds the following parameters to the RabbitMQ template:

    • ssl_verify
    • tag_families
    • nodes
    • nodes_regexes
    • queues_regexes
  2. Sets defaults according to the example file:

  3. Add parameter validation to fail fast

@alvin-huang alvin-huang force-pushed the add_rabbitmq_params branch 3 times, most recently from 5128924 to e0a939c Compare December 24, 2016 05:07
@alvin-huang alvin-huang force-pushed the add_rabbitmq_params branch 6 times, most recently from a37da35 to 1deb748 Compare December 24, 2016 16:09
@truthbk
Copy link
Copy Markdown
Member

truthbk commented Dec 30, 2016

Thank a lot for this @alvin-huang! This looks pretty much ready at first glance, I'll take a closer look and hopefully merge soon! Thanks a bunch for updating the tests too! 🙇

@qnm
Copy link
Copy Markdown

qnm commented Jan 23, 2017

Having the queue_regexes param would be a huge win for my team. 👍

@truthbk
Copy link
Copy Markdown
Member

truthbk commented Mar 3, 2017

I just took a look at this and it definitely doesn't look like it'll cause any breakage for older manifests. I'm merging this, will run a few tests to decide if there's any (unlikely) tweaking necessary. Thank you very much @alvin-huang, for the PR and the detailed explanation.

@truthbk truthbk merged commit e850cb5 into DataDog:master Mar 3, 2017
@truthbk truthbk added this to the 1.10.0 milestone Mar 3, 2017
cegeka-jenkins pushed a commit to cegeka/puppet-datadog_agent that referenced this pull request Jan 31, 2018
)

* additional params for rabbitmq.yaml template per dd example

* fixing tests with new rabbitmq params
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants