Skip to content

Add ceph integration#293

Merged
truthbk merged 1 commit intoDataDog:masterfrom
stamak:ceph
Mar 10, 2017
Merged

Add ceph integration#293
truthbk merged 1 commit intoDataDog:masterfrom
stamak:ceph

Conversation

@stamak
Copy link
Copy Markdown
Contributor

@stamak stamak commented Dec 28, 2016

No description provided.

@truthbk
Copy link
Copy Markdown
Member

truthbk commented Mar 3, 2017

Hi @stamak! Thanks a lot for this. I'm sorry it took me so long to acknowledge this and start reviewing. Can I ask you for a favor? Could you please rebase this to the latest master (there was an issue in the CI that has now been fixed).

Ideally, we would also like to have some spec tests to keep some sort of track in the CI for the behavior of the manifest and avoid breaking things in the future, so if you could write something to that regard that would be great. If you don't have the time, please just let me know and I'll try to write those tests myself.

Thank you very much for your work! 👍

@stamak stamak force-pushed the ceph branch 2 times, most recently from f3b890a to e2a4d21 Compare March 6, 2017 21:52
@stamak
Copy link
Copy Markdown
Contributor Author

stamak commented Mar 6, 2017

@truthbk done ;)

@truthbk
Copy link
Copy Markdown
Member

truthbk commented Mar 7, 2017

Awesome stuff @stamak, I'll give this another pass later and almost certainly merge! Big 🏅 for the tests!

@truthbk
Copy link
Copy Markdown
Member

truthbk commented Mar 10, 2017

We should make the actual integration configurable, so the ceph check parameters can be tweaked, but since this covers 99% of the cases I'll be merging this in.

@truthbk truthbk merged commit 240b024 into DataDog:master Mar 10, 2017
cegeka-jenkins pushed a commit to cegeka/puppet-datadog_agent that referenced this pull request Jan 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants