Skip to content

Add custom MySQL metrics#316

Merged
truthbk merged 3 commits intoDataDog:masterfrom
yrcjaya:add-mysql-custom-queries
Jul 11, 2018
Merged

Add custom MySQL metrics#316
truthbk merged 3 commits intoDataDog:masterfrom
yrcjaya:add-mysql-custom-queries

Conversation

@yrcjaya
Copy link
Copy Markdown
Contributor

@yrcjaya yrcjaya commented Mar 22, 2017

Manage custom MySQL metrics

@truthbk
Copy link
Copy Markdown
Member

truthbk commented May 5, 2017

@yrcjaya I know this has been a while ago, I'm sorry this got cut from the previous release. I'm hoping to get this in now, all we're missing at the moment for this one are the spec tests which will help us keep this healthy in time and avoid breaking anything. If you could take a stab at those, that'd be really awesome 🙇

@truthbk truthbk added this to the 1.11.0 milestone May 11, 2017
@truthbk
Copy link
Copy Markdown
Member

truthbk commented Jul 20, 2017

@yrcjaya any chance you could give those spec tests a shot? 1.11.0 will be released soon and I would love to include this in it. Let me know! Thanks :)

@esg-gustavo
Copy link
Copy Markdown

esg-gustavo commented Dec 27, 2017

@truthbk @yrcjaya Any idea of when this will be merged? Has someone from Datadog had a chance to write those spec tests?

@yrcjaya
Copy link
Copy Markdown
Contributor Author

yrcjaya commented Apr 1, 2018

@truthbk I took some time to make the spec, I don't have much of background of ruby coding. Will look into merging the conflict next weekend

@yrcjaya
Copy link
Copy Markdown
Contributor Author

yrcjaya commented Apr 1, 2018

@truthbk Merged the conflicting commit.

truthbk
truthbk approved these changes Jul 11, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@truthbk truthbk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotta fix a little thing to explicitly say Array $queries is Optional, but I'll do that for you! Thank you! 👌

@truthbk truthbk merged commit c297b01 into DataDog:master Jul 11, 2018
@truthbk truthbk modified the milestones: 1.11.0, 2.3.0 Jul 11, 2018
@truthbk truthbk mentioned this pull request Jul 11, 2018
Closed
cegeka-jenkins pushed a commit to cegeka/puppet-datadog_agent that referenced this pull request Apr 6, 2020
@yrcjaya @truthbk
Add custom MySQL metrics (DataDog#316)
e241fa6 
* Add custom MySQL metrics

* Spec custom MySQL metrics

* Cleanup datadog_agent_integrations_mysql_spec.rb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@truthbk truthbk truthbk approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.3.0

Development

Successfully merging this pull request may close these issues.

3 participants

@yrcjaya @truthbk @esg-gustavo
⚡