Redis updates - Allow command_stats#327
Merged
truthbk merged 3 commits intoDataDog:masterfrom May 31, 2017
italicninja:redis_updates
Merged
Redis updates - Allow command_stats#327truthbk merged 3 commits intoDataDog:masterfrom italicninja:redis_updates
truthbk merged 3 commits intoDataDog:masterfrom
italicninja:redis_updates
Conversation
truthbk
reviewed
May 16, 2017
Member
truthbk
left a comment
There was a problem hiding this comment.
This looks good to go, but if you could add a spec test to cover this new config file, that would be fantastic! Let me know if you can't do that. 🙇
Contributor
Author
|
Hope thats all, Specs are new to me 😄 |
Member
|
Thanks so much @IanCrouch - that was exactly it. Merging. |
cegeka-jenkins
pushed a commit
to cegeka/puppet-datadog_agent
that referenced
this pull request
Jan 31, 2018
* Updating redis.pp to include new command_stats * Add command_stats to template * Updating redis spec
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Datadog added a new option for redis
command_statshttp://docs.datadoghq.com/integrations/redis/
https://github.com/Datadog/integrations-core/blob/master/redisdb/conf.yaml.example#L57