etc/dd-agent should be ensured to be a directory not merely present#332
Merged
truthbk merged 2 commits intoDataDog:masterfrom Jun 16, 2017
Merged
etc/dd-agent should be ensured to be a directory not merely present#332truthbk merged 2 commits intoDataDog:masterfrom
truthbk merged 2 commits intoDataDog:masterfrom
Conversation
…ectory init.pp should ensure that /etc/dd-agent is a directory, not just ensure present
Member
|
Thank you @butangero nice catch! This is absolutely correct, merging. 🙇 |
cegeka-jenkins
pushed a commit
to cegeka/puppet-datadog_agent
that referenced
this pull request
Jan 31, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the agent_version is set to absent, the datadog-agent package doesn't get installed, thus /etc/dd-agent doesn't get created. This causes the file resource for /etc/dd-agent in init.pp to create it as an empty file instead of a directory. Because it's an empty file, further dependent resources like /etc/dd-agent/conf.d are unable to be created. By ensuring it's a directory, even if the package version is set to absent, you'll still get clean puppet runs.