Skip to content

Add support for multiple instances of Elasticsearch.#333

Merged
truthbk merged 1 commit intoDataDog:masterfrom
stantona:add-instances-to-elasticsearch-manifest
Jul 13, 2017
Merged

Add support for multiple instances of Elasticsearch.#333
truthbk merged 1 commit intoDataDog:masterfrom
stantona:add-instances-to-elasticsearch-manifest

Conversation

@stantona
Copy link
Copy Markdown
Contributor

@stantona stantona commented Jun 21, 2017

This allows monitoring of multiple instances of Elasticsearch. This follows the same pattern used by 'mysql.pp'.

This follows the same pattern used by 'mysql.pp'. The default values for the
'cluster_stats', 'pshard_stats' or 'pending_task_stats' fields are used if
the parameters are not set in each instance declaration.
@stantona
Copy link
Copy Markdown
Contributor Author

stantona commented Jul 7, 2017

I'm wondering if there's any interest in this PR?

@truthbk truthbk self-requested a review July 13, 2017 08:44
@truthbk truthbk added this to the 1.11.0 milestone Jul 13, 2017
@truthbk
Copy link
Copy Markdown
Member

truthbk commented Jul 13, 2017

@stantona there is! I'm sorry about the delay, and thanks for pinging us. Reviewing this now!

Copy link
Copy Markdown
Member

@truthbk truthbk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Merging! :shipit:

it { should contain_file(conf_file).with_content(%r{ - tag1:key1}) }
end

context 'with multiple instances set' do
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍰 thanks for these tests!

@truthbk truthbk merged commit 5ef1514 into DataDog:master Jul 13, 2017
cegeka-jenkins pushed a commit to cegeka/puppet-datadog_agent that referenced this pull request Jan 31, 2018
This follows the same pattern used by 'mysql.pp'. The default values for the
'cluster_stats', 'pshard_stats' or 'pending_task_stats' fields are used if
the parameters are not set in each instance declaration.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants