Skip to content

Don't fail if there is no value in hiera#334

Merged
truthbk merged 1 commit intoDataDog:masterfrom
mtougeron:default-hiera-lookup-values
Jul 5, 2017
Merged

Don't fail if there is no value in hiera#334
truthbk merged 1 commit intoDataDog:masterfrom
mtougeron:default-hiera-lookup-values

Conversation

@mtougeron
Copy link
Copy Markdown
Contributor

If the $hiera_tags or $hiera_integrations is true but the datadog_agent::tags or datadog_agent::integrations are not defined (respectively) the puppet run shouldn't fail. So default an empty value.

@irabinovitch irabinovitch requested review from jeremy-lq and truthbk July 1, 2017 00:41
Copy link
Copy Markdown
Member

@jeremy-lq jeremy-lq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@truthbk truthbk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you for this @mtougeron 🙇 :shipit:

@truthbk truthbk merged commit c98bf45 into DataDog:master Jul 5, 2017
@mtougeron
Copy link
Copy Markdown
Contributor Author

@truthbk Thanks!

@mtougeron mtougeron deleted the default-hiera-lookup-values branch July 12, 2017 16:10
cegeka-jenkins pushed a commit to cegeka/puppet-datadog_agent that referenced this pull request Jan 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants