Skip to content

added kafka integration#343

Merged
truthbk merged 3 commits intoDataDog:masterfrom
jensendw:kafka-integration
Feb 27, 2018
Merged

added kafka integration#343
truthbk merged 3 commits intoDataDog:masterfrom
jensendw:kafka-integration

Conversation

@jensendw
Copy link
Copy Markdown
Contributor

@truthbk Added kafka integration + tests, followed the same pattern as with mongo integration so should be relatively solid.

@truthbk truthbk added this to the triage milestone Jul 26, 2017
@truthbk truthbk self-requested a review July 26, 2017 15:58
@truthbk
Copy link
Copy Markdown
Member

truthbk commented Jul 26, 2017

@jensendw with spec tests and all! This looks very good already. I'll give it a closer review, and should get it merged soon! Thank you so much! :)

@jensendw
Copy link
Copy Markdown
Contributor Author

@truthbk Any news on when this will be merged and released? I was hoping to stop using my forked module.

@truthbk
Copy link
Copy Markdown
Member

truthbk commented Feb 5, 2018

@jensendw I'm sorry this got left behind. There were two kafka PRs, quite similar, but actually this was probably more feature rich and the other one got merged instead. I am going to reintroduce this one for the 2.0 module we are preparing to enable the multi-instance support you implemented. Thank you and apologies.

@truthbk truthbk modified the milestones: triage, 2.0.0 Feb 5, 2018
@jensendw
Copy link
Copy Markdown
Contributor Author

jensendw commented Feb 5, 2018

No worries, thanks for letting me know

@truthbk
Copy link
Copy Markdown
Member

truthbk commented Feb 27, 2018

After merging #387, going to merge this now - additional work will be conducted in a separate PR to make the manifest backward compatible as Kafka is a very important integration for many of our customers and we'd like to make the "upgrade" seamless fo them. I will merge this now once the CI tests run 💚

Copy link
Copy Markdown
Member

@truthbk truthbk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! Thank you @jensendw, I will make some small changes to your work to make the manifest backward-compatible, but this is awesome! 🙇

@truthbk truthbk merged commit 7f58ca5 into DataDog:master Feb 27, 2018
cegeka-jenkins pushed a commit to cegeka/puppet-datadog_agent that referenced this pull request Apr 6, 2020
* added kafka integration

* fix parameter description
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants