Add network integration to puppet module#346
Merged
truthbk merged 1 commit intoDataDog:masterfrom Nov 23, 2017
Merged
Conversation
jameynelson
changed the title
Member
|
Thanks @jameynelson! Looks good right off the bat... thanks a bunch for the spec tests. I'll review soon and provide feedback, if any at all. 🙇 |
truthbk
approved these changes
Nov 23, 2017
Member
truthbk
left a comment
truthbk
left a comment
There was a problem hiding this comment.
Looks good to go! Thanks @jameynelson awesome work here 🙇
cegeka-jenkins
pushed a commit
to cegeka/puppet-datadog_agent
that referenced
this pull request
Jan 31, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to add the ability to control the network integration and it's details to the puppet module. I have included some rudimentary tests also.