Puppet v4 upgrades - subset of @bittner work in #362#370
Merged
Conversation
sjenriquez
approved these changes
Nov 27, 2017
cegeka-jenkins
pushed a commit
to cegeka/puppet-datadog_agent
that referenced
this pull request
Jan 31, 2018
) * Bump versions for dependencies Add more versions for supported OSes * Use system_gem instead of puppetserver_gem * Revert "Use system_gem instead of puppetserver_gem" This reverts commit df2cfcd. * [metadata] puppetserver is a _soft_ dependency that would break older puppets - install manually
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses some of the issues brought up by @bittner in PR #362. Unfortunately we've had to remove the changes pertaining to
puppetserver_gemas the alternative proposedtkishel/system_gemwould definitely break legacy puppet systems supported by the1.xversion of the module.Also, please note that the
puppetserver_gemis a soft dependency for reporting and must be installed manually (please take a look at the existing README for more information). Should you need to address PUP-6134 - you are likely able to do so by installing https://forge.puppet.com/tkishel/system_gem manually, in the same way you'd installpuppetserver_gemand overriding the value here: https://github.com/DataDog/puppet-datadog-agent/blob/master/manifests/init.pp#L197 tosystem_gem.