[apt] Only grep for last 8 characters as this is what apt-key list returns#374
Merged
[apt] Only grep for last 8 characters as this is what apt-key list returns#374
Conversation
[key] get last eight characters with regex subst
Member
Author
|
@szponek mind to give this a look before I merge? Tried it on puppet 5/4, and ran the older puppet spec suite successfully. |
|
My appologies @truthbk for being a bit late to the party, but yeah, that works fine for me. |
cegeka-jenkins
pushed a commit
to cegeka/puppet-datadog_agent
that referenced
this pull request
Jan 31, 2018
…turns (DataDog#374) * Only grep for last 8 characters as this is what apt-key list returns * [ubuntu] fix key substring extraction-interpolation [key] get last eight characters with regex subst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #373 - we have to resort to something that will work on older puppets.
Big thanks to @szponek for bringing this up and his more elegant original fix, unfortunately we have to stay backward compatible, so had to resort to this.