Skip to content

parameterize docker_daemon.yaml#378

Merged
truthbk merged 3 commits intoDataDog:masterfrom
flyinprogrammer:master
Feb 5, 2018
Merged

parameterize docker_daemon.yaml#378
truthbk merged 3 commits intoDataDog:masterfrom
flyinprogrammer:master

Conversation

@flyinprogrammer
Copy link
Copy Markdown
Contributor

No description provided.

@truthbk truthbk added this to the 1.13.0 milestone Dec 15, 2017
@truthbk
Copy link
Copy Markdown
Member

truthbk commented Dec 15, 2017

As always, thanks @flyinprogrammer! Really awesome to see you around here again :)

Can you take a look at the failing tests? 😊 (looks like minor issues in the spec test)

@truthbk truthbk modified the milestones: 1.13.0, 2.0.0 Dec 15, 2017
@flyinprogrammer
Copy link
Copy Markdown
Contributor Author

Hey @truthbk! happy to be back 😄!

It seems this new config didn't break production 👍 - let me know you desire more edits!

@truthbk
Copy link
Copy Markdown
Member

truthbk commented Feb 5, 2018

I might make some changes to the way we render the YAML, but this looks good to me. Great to see you add support for all those additional check features. Thank you! 🙇

Copy link
Copy Markdown
Member

@truthbk truthbk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🐳

@truthbk truthbk merged commit cd3eea2 into DataDog:master Feb 5, 2018
cegeka-jenkins pushed a commit to cegeka/puppet-datadog_agent that referenced this pull request Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants