Fix beta6 fact

[scottgeary]

In some situations facts are likely returned as a string. Any non-empty string can be interpreted as true when building a conditional. See https://puppet.com/docs/puppet/5.3/lang_facts_and_builtin_vars.html#handling-boolean-facts-in-older-puppet-versions

Ensure we're interpreting ::apt_agent6_beta_repo as a valid boolean, so we don't get half-baked package removals.

Example debug message confirming the various ways to interpret the fact:

Debug: Scope(Class[Datadog_agent::Ubuntu]): Fact ::apt_agent6_beta_repo=false type=string is_true=true str2bool=false

puppet --version
3.8.7

[truthbk]

Thank you for this fix @scottgeary

Tests are good but we've got some linting issues:

manifests/ubuntu.pp:40:only_variable_string:WARNING:string containing only a variable
manifests/ubuntu.pp:53:only_variable_string:WARNING:string containing only a variable
manifests/ubuntu.pp:40:variables_not_enclosed:WARNING:variable not enclosed in {}
manifests/ubuntu.pp:53:variables_not_enclosed:WARNING:variable not enclosed in {}

Can you address that? We could just add a lint:ignore:only_variable_string, because there's no real clean way of checking for types in older puppets, I know =~ doesn't work in 3.7.

Thanks a lot for this!

[truthbk]

I'll merge and fix the linting on my end, thanks @scottgeary

[truthbk]

merging! 🚀