redhat: stop specifying service resource provider 'redhat'#401
Merged
truthbk merged 1 commit intoDataDog:masterfrom Mar 2, 2018
milescrabill:redhat-stop-overriding-service-provider
Merged
redhat: stop specifying service resource provider 'redhat'#401truthbk merged 1 commit intoDataDog:masterfrom milescrabill:redhat-stop-overriding-service-provider
truthbk merged 1 commit intoDataDog:masterfrom
milescrabill:redhat-stop-overriding-service-provider
Conversation
Contributor
Author
|
See: #402 |
truthbk
approved these changes
Mar 2, 2018
Member
truthbk
left a comment
truthbk
left a comment
There was a problem hiding this comment.
Looks good! Thanks for spotting this!
cegeka-jenkins
pushed a commit
to cegeka/puppet-datadog_agent
that referenced
this pull request
Apr 6, 2020
…lt for osfamily) (DataDog#401)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default provider for "
operatingsystemmajrelease==7andosfamily==redhat" is systemd. See here.This PR removes the override to use the
redhatprovider, which can cause issues on newer RHEL/CentOS, and instead falls back to the default, which should be safe.