Merged
Conversation
That key is not used anymore, let's stop installing it
Member
|
This is fine, but it would break the manifest's interface.... it should be safe, but I've gotta think about the right thing to do here:
|
Member
Author
|
Thanks @truthbk, let me know if I can help with any of the options. Tests seem to be failing, having a look... |
cegeka-jenkins
pushed a commit
to cegeka/puppet-datadog_agent
that referenced
this pull request
Apr 6, 2020
* [apt] Stop installing old apt key That key is not used anymore, let's stop installing it * Remove occurence of `other_keys`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
That key is not used anymore, let's stop installing it.
(not sure the tests pass, will fix if they're broken)