agent6 config: include statsd forward params#408
agent6 config: include statsd forward params#408truthbk merged 1 commit intoDataDog:masterfrom djova:djova/agent6-include-statsd-forward-metrics
Conversation
`statsd_forward_host` and `statsd_forward_port` are supported by agent6 so they should be included in the config file.
| 'dogstatsd_socket' => $dogstatsd_socket, | ||
| 'dogstatsd_non_local_traffic' => $non_local_traffic, | ||
| 'statsd_forward_host' => $statsd_forward_host, | ||
| 'statsd_forward_port' => $statsd_forward_port, |
There was a problem hiding this comment.
These parameters can actually be included in the $extra_config hash parameter available for additional options.
There was a problem hiding this comment.
Yeah, and that's what we're doing now, but then isn't it misleading to have the corresponding parameters for the actual class be ignored with agent6? If the intention is to provide those parameters via extra_config then should the puppet class parameters be removed?
There was a problem hiding this comment.
Let's honor this, the deep_merge() should probably be seamless.
It's tough keeping an interface that was defined for agent5 with the new datadog.yaml approach in agent6. But this is a 1-to-1 mapping so no reason not to merge. Sorry we kept it in the backburner for so long.
Thanks.
| 'dogstatsd_socket' => $dogstatsd_socket, | ||
| 'dogstatsd_non_local_traffic' => $non_local_traffic, | ||
| 'statsd_forward_host' => $statsd_forward_host, | ||
| 'statsd_forward_port' => $statsd_forward_port, |
There was a problem hiding this comment.
Let's honor this, the deep_merge() should probably be seamless.
It's tough keeping an interface that was defined for agent5 with the new datadog.yaml approach in agent6. But this is a 1-to-1 mapping so no reason not to merge. Sorry we kept it in the backburner for so long.
Thanks.
`statsd_forward_host` and `statsd_forward_port` are supported by agent6 so they should be included in the config file.
2 participants
statsd_forward_hostandstatsd_forward_portare supported by agent6 so they should be included in the config file.