Bug Fix: Faulty check on Redhat causes repeat reinstalls of agent.#412
Merged
truthbk merged 1 commit intoDataDog:masterfrom Mar 14, 2018
Merged
Conversation
The factor check for old legacy datadag repo was incorrect and would always return true if a file exists yet was empty. This results in one Puppet run removing the agent, then the next Puppet run adding it again.
cegeka-jenkins
pushed a commit
to cegeka/puppet-datadog_agent
that referenced
this pull request
Apr 6, 2020
…ataDog#412) The factor check for old legacy datadag repo was incorrect and would always return true if a file exists yet was empty. This results in one Puppet run removing the agent, then the next Puppet run adding it again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The factor check for old legacy datadag repo was incorrect and would always return true if a file exists yet was empty. This results in one Puppet run removing the agent, then the next Puppet run adding it again.
Reproducing: