Skip to content

[php-fpm] Add a parameter for ping_reply#417

Merged
truthbk merged 2 commits intoDataDog:masterfrom
Aramack:mpenny_php_fpm_ping_reply
Jul 10, 2018
Merged

[php-fpm] Add a parameter for ping_reply#417
truthbk merged 2 commits intoDataDog:masterfrom
Aramack:mpenny_php_fpm_ping_reply

Conversation

@Aramack
Copy link
Copy Markdown
Contributor

@Aramack Aramack commented Mar 19, 2018

Add ping_reply as a parameter to the php_fpm integration. Defaults to pong if not provided as specified in https://github.com/DataDog/integrations-core/tree/master/php_fpm#configuration.

For backwards compatibility check if the parameter is set with a ternary operator in the .erb file:

ping_reply: <%= instance['ping_reply'] ? instance['ping_reply'] : 'pong' %>

Copy link
Copy Markdown
Member

@truthbk truthbk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you @Aramack, and special 🍰 for the tests!

@truthbk truthbk merged commit fac7fb6 into DataDog:master Jul 10, 2018
@truthbk truthbk added this to the 2.3.0 milestone Jul 11, 2018
cegeka-jenkins pushed a commit to cegeka/puppet-datadog_agent that referenced this pull request Apr 6, 2020
* [php-fpm] Add a parameter for ping_reply

* [php-fpm] Fix syntax error in test (DataDog#417)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants