Allow specification of CA cert for HTTP status check#418
Merged
truthbk merged 5 commits intoDataDog:masterfrom Apr 16, 2018
ffleming:fsf/agent_ca_cert
Merged
Allow specification of CA cert for HTTP status check#418truthbk merged 5 commits intoDataDog:masterfrom ffleming:fsf/agent_ca_cert
truthbk merged 5 commits intoDataDog:masterfrom
ffleming:fsf/agent_ca_cert
Conversation
added 3 commits
February 16, 2018 11:49
previously, the ca_certs conditional was nested in the 'tls cert check is disabled' conditional. while it doesn't make a _ton_ of sense to provide a ca cert when you aren't checking it, allowing users to do so makes migrating from an unchecked to a checked workflow easier. I don't see a downside to allowing this behavior.
Contributor
Author
|
All build errors appear to be of the form: I got that with Cheers! |
added 2 commits
March 23, 2018 09:02
This reverts commit e875f27.
cegeka-jenkins
pushed a commit
to cegeka/puppet-datadog_agent
that referenced
this pull request
Apr 6, 2020
* add ca_certs configuration * test for ca_certs line * fix scoping bug previously, the ca_certs conditional was nested in the 'tls cert check is disabled' conditional. while it doesn't make a _ton_ of sense to provide a ca cert when you aren't checking it, allowing users to do so makes migrating from an unchecked to a checked workflow easier. I don't see a downside to allowing this behavior. * whitespace to trigger build * Revert "whitespace to trigger build" This reverts commit e875f27.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows Puppet to specify
ca_certsfor HTTP status checks