Conversation
…ed hashmap to configure yaml file; added datadog_process_footer.conf.erb to handle datadog.conf generation; updated README.md with new fields
Contributor
|
lgtm! I'll leave to Jaime for the 👍 |
…r-process-agent-scrubbing
truthbk
approved these changes
Apr 25, 2018
Member
truthbk
left a comment
truthbk
left a comment
There was a problem hiding this comment.
Looks good to me! We'll test and release soon - probably next week. Awesome work! 🍰
truthbk
deleted the
moises.botarro/adding-new-config-fields-for-process-agent-scrubbing
branch
cegeka-jenkins
pushed a commit
to cegeka/puppet-datadog_agent
that referenced
this pull request
Apr 6, 2020
…ataDog#426) * Added default values for scrub_args and custom_sensitive_words; updated hashmap to configure yaml file; added datadog_process_footer.conf.erb to handle datadog.conf generation; updated README.md with new fields * Added test for conf and yaml files * Format changes * Fixed regex patterns on data scrubbing tests * [process][spec] address test-case conflict - `enabled` not `process_enabled`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fields used by the process-agent's new feature, process args scrubbing, have been added on the templates for datadog.conf and datadog.yaml files.