[tomcat] jmx_url support + reports regex extraction should use undef (Thanks @evansj)#482
Merged
[tomcat] jmx_url support + reports regex extraction should use undef (Thanks @evansj)#482
undef (Thanks @evansj)#482Conversation
cegeka-jenkins
pushed a commit
to cegeka/puppet-datadog_agent
that referenced
this pull request
Apr 6, 2020
…` (Thanks @evansj) (DataDog#482) * Add jmx_url parameter to tomcat integration * Fix tags indenting * Fix hostname_extraction_regex, should be undef * Fix more nil / undef confusion * [reports] parameter typo - missing comma
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is based off #460, all credit goes to @evansj!
(Apologies for not merging this in when we should've)