Custom integration defined type bugfix

[o0oxid]

Seems like there is a regression in 2.4.0 release. We setup datadog custom integrations via defined type. After upgrade to 2.4.0 puppet fails with following errors:

Error: Could not set 'file' on ensure: No such file or directory @ dir_s_mkdir - /etc/datadog-agent/conf.d/check_snapshot.d/conf.yaml20190104-21120-1j3khxt.lock (file:
/etc/puppetlabs/code/modules/datadog_agent/manifests/integration.pp, line: 19)
Error: Could not set 'file' on ensure: No such file or directory @ dir_s_mkdir - /etc/datadog-agent/conf.d/check_snapshot.d/conf.yaml20190104-21120-1j3khxt.lock (file:
/etc/puppetlabs/code/modules/datadog_agent/manifests/integration.pp, line: 19)
Wrapped exception:
No such file or directory @ dir_s_mkdir - /etc/datadog-agent/conf.d/check_snapshot.d/conf.yaml20190104-21120-1j3khxt.lock
Error: /Stage[main]/Datadog_integrations::Snapshot_monitor/Datadog_agent::Integration[check_snapshot]/File[/etc/datadog-agent/conf.d/check_snapshot.d/conf.yaml]/ensure: change from 'absent' to 'file' failed: Could not set 'file' on ensure: No such file or directory @ dir_s_mkdir - /etc/datadog-agent/conf.d/check_snapshot.d/conf.yaml20190104-21120-1j3khxt.lock (file: /etc/puppetlabs/code/modules/datadog_agent/manifests/integration.pp, line: 19)

The root cause is puppet fails to create config.yaml resource because /etc/datadog-agent/${integration}.d/ directory is missing.

With predefined integrations everything is fine though, as necessary integration directories are created by datadog-agent RPM package.

[truthbk]

Great fix, and you're absolutely right this was a regression on our part with the new locations.