Fix reverse content match#524
Merged
truthbk merged 7 commits intoDataDog:masterfrom May 20, 2019
dorg-kanderson:fix-reverse-content-match
Merged
Fix reverse content match#524truthbk merged 7 commits intoDataDog:masterfrom dorg-kanderson:fix-reverse-content-match
truthbk merged 7 commits intoDataDog:masterfrom
dorg-kanderson:fix-reverse-content-match
Conversation
truthbk
reviewed
May 14, 2019
Member
truthbk
left a comment
truthbk
left a comment
There was a problem hiding this comment.
This is almost ready. A spec test would be perfect if you could please add that! 🙇
Contributor
Author
|
Please review and let me know if I constructed the spec correctly. |
truthbk
suggested changes
May 14, 2019
truthbk
suggested changes
May 14, 2019
Member
truthbk
left a comment
truthbk
left a comment
There was a problem hiding this comment.
Found the last missing detail. Once you fix this tests will be ✅
Contributor
Author
|
Please let me know if you need anything additional from me to get this merged. Thank you! |
truthbk
approved these changes
May 20, 2019
Member
truthbk
left a comment
truthbk
left a comment
There was a problem hiding this comment.
Let's merge this guy! 🙇
Thank you @dorg-kanderson!
cegeka-jenkins
pushed a commit
to cegeka/puppet-datadog_agent
that referenced
this pull request
Apr 6, 2020
* Update http_check.yaml.erb * Update http_check.pp * Update datadog_agent_integrations_http_check_spec.rb * Update datadog_agent_integrations_http_check_spec.rb * Update datadog_agent_integrations_http_check_spec.rb * Update datadog_agent_integrations_http_check_spec.rb * Update http_check.yaml.erb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add reverse_content_match boolean to http_check