Skip to content

Track integration configuration directories#525

Merged
truthbk merged 2 commits intoDataDog:masterfrom
Aramack:Aramack/track_conf_directory
May 28, 2019
Merged

Track integration configuration directories#525
truthbk merged 2 commits intoDataDog:masterfrom
Aramack:Aramack/track_conf_directory

Conversation

@Aramack
Copy link
Copy Markdown
Contributor

@Aramack Aramack commented May 17, 2019

As described in #512, when $conf_dir_purge is true, but $agent5_enable is false, puppet errors because it purges the untracked integration conf.d files, which are expected to be present.

This change tracks all conf.d files in the all the integration classes. This ensures they won't be purge by puppet when $conf_dir_purge is true.

Copy link
Copy Markdown
Member

@truthbk truthbk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, this was a big tedious PR, I hope you macro'd your way through it :)

We'll merge this and unless we find anything weird during QA, we'll make sure this goes out with the next release! 🚀

Thank you @Aramack

@truthbk truthbk merged commit 2f03da3 into DataDog:master May 28, 2019
@truthbk truthbk added this to the 2.6.0 milestone May 28, 2019
cegeka-jenkins pushed a commit to cegeka/puppet-datadog_agent that referenced this pull request Apr 6, 2020
* Track integration configuration directories

* Fix path to redisdb configuration directory
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants