Allow open files limit param

[rmrf-run]

Allow users to configure open files limit with hiera or manifests

[albertvaka]

Hi @mylivingweb and thanks for your contribution!

Can you make the option default to undef, and only set it in logs_config if it has been defined? This way, if it's not set, the agent will use its default value, and if that default ever changes, we won't have to change it also here.

It is definitely a good idea to expose this config param via the puppet module, but I think it's better to avoid duplicating default values in puppet and the agent code.

[rmrf-run]

makes sense, i'll work on it

[albertvaka]

Can I ask you one more change? Can we call this logs_open_files_limit and mention in the documentation that this is only for the logs agent? Could be something like Set the max open files for the logs agent.

Otherwise, people might think this affect all datadog agents, while it only affects the logs agent.

[rmrf-run]

sure, i can rename it, it is actually breaking in our dev environment due to variable reassignment so i need to fix that real quick

[rmrf-run]

tested in our dev environment with the latest commit.
datadog_agent::logs_open_files_limit: 2000
or

class { "datadog_agent":
    api_key               => "***",
    logs_enabled          => true,
    logs_open_files_limit => 2000,
  }

[rmrf-run]

any word on merging?

[albertvaka]

Looks good to me! Thanks for the patch and sorry for the delay, I was on vacation and I'm just catching up 🌴🙂

[rmrf-run]

awesome, thanks