Change unless -> not#558
Merged
albertvaka merged 2 commits intomasterfrom Sep 3, 2019
Merged
Conversation
Unless starts a new conditional block, so we needed an extra end keyword.
truthbk
reviewed
Sep 3, 2019
Member
truthbk
left a comment
truthbk
left a comment
There was a problem hiding this comment.
Can we add a tiny spec test to catch this (previously) broken scenario? It would've been nice to have caught this earlier with the tests (I think this was me introducing it too).
Other than that, LGTM.
truthbk
approved these changes
Sep 3, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
unlessstarts a new conditional block, so we needed an extraendkeyword (which was incorrectly nested).