remove unnecessary restart using Exec

[jvanbrunschot]

Currently the restart breaks whenever Datadog is not running yet.

Looking at the code, the restart seems to be unnecessary. No config changes are made between the installation of the package and the definition of the service.

If the Datadog service is not running (but installed) the exec will return a failure.

Notice: /Stage[main]/Datadog_agent::Windows::Agent6/Exec[DatadogRestart]/returns: could not send control=1: The service has not been started.

[albertvaka]

Indeed, this can be removed. The agent is already restarted automatically when needed by notifying the Service.

Thanks for catching this, and thanks for testing on Windows :)

[jvanbrunschot]

@albertvaka

We were actually waiting for Windows support when we saw the "add windows support" PR pending. :)

I wish we could disable the installation part in Windows:

We create a pre-build AMI with all software installed and do the configuration part (like adding the DD api key and tags) whenever we AutoScale. This keeps the configuration part on boot small. Currently the Windows support downloads the MSI which is not ideal for us.

But I/we appreciate the effort that's put into getting Windows support for the DD agent 👍

[albertvaka]

Puppet is smart enough to not install the agent again if it's already installed, but it's true that we still always download the MSI anyway.

If we find a way to only download the MSI only if the agent needs to be installed, I think that would cover your use case.

[albertvaka]

Something like this: #563