Add support for Oracle Linux#574
Merged
albertvaka merged 3 commits intomasterfrom Nov 19, 2019
Merged
Conversation
KSerrania
reviewed
Nov 18, 2019
Contributor
KSerrania
left a comment
KSerrania
left a comment
There was a problem hiding this comment.
Does OracleLinux need to be added to the metadata.json file and this definition in the spec tests?
Contributor
Author
|
Good catch. I'm not sure it adds much value to add it to the test OS array, and it will make tests longer. I'm a bit inclined towards not adding it, but quite undecided. What do you think? |
Contributor
|
Looking at the tests, I think we're not using this list to create our test matrix. All Linux tests seem to run on xenial, according to the Travis config (which is a separate issue). We can probably add it to the list, it won't change the current CI. |
Contributor
Author
|
You are totally right, updated. |
KSerrania
approved these changes
Nov 19, 2019
cegeka-jenkins
pushed a commit
to cegeka/puppet-datadog_agent
that referenced
this pull request
Apr 6, 2020
Add support for Oracle Linux
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #573