Skip to content

Add Network Performance Monitoring support#584

Merged
albertvaka merged 5 commits intoDataDog:masterfrom
asenci:asenci/system-probe
Nov 29, 2019
Merged

Add Network Performance Monitoring support#584
albertvaka merged 5 commits intoDataDog:masterfrom
asenci:asenci/system-probe

Conversation

@asenci
Copy link
Copy Markdown
Contributor

@asenci asenci commented Nov 28, 2019

Disabled by default, can be enabled by instantializing the datadog_agent::system_probe class (process_enabled needs to be enabled on datadog_agent):

class { 'datadog_agent': process_enabled => true }
class { 'datadog_agent::system_probe': enabled => true }

Copy link
Copy Markdown
Contributor

@albertvaka albertvaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for adding this! I've added one small comment, but I think it looks good :)

Comment thread manifests/system_probe.pp Outdated
@albertvaka
Copy link
Copy Markdown
Contributor

Also, the CI seems to be unhappy about some coding style things. Could you address them?

@asenci
Copy link
Copy Markdown
Contributor Author

asenci commented Nov 28, 2019

Also, the CI seems to be unhappy about some coding style things. Could you address them?

Sure thing. I'll have a look and update the PR. :)

asenci and others added 2 commits November 29, 2019 14:55
Co-Authored-By: Albert Vaca <albertvaka@gmail.com>
@albertvaka
Copy link
Copy Markdown
Contributor

LGTM, thanks again for the contribution!

@albertvaka albertvaka merged commit 54b2270 into DataDog:master Nov 29, 2019
cegeka-jenkins pushed a commit to cegeka/puppet-datadog_agent that referenced this pull request Apr 6, 2020
Disabled by default, can be enabled by instantializing the datadog_agent::system_probe class (process_enabled needs to be enabled on datadog_agent).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants