Migrate to PDK#597
Conversation
albertvaka
force-pushed
the
albertvaka/pdk-release
branch
7 times, most recently
from
f6a2091 to
19451b9
Compare
albertvaka
force-pushed
the
albertvaka/pdk-release
branch
from
19451b9 to
8b3f304
Compare
truthbk
left a comment
truthbk
left a comment
There was a problem hiding this comment.
I don't see anything wrong with this, added a couple of questions, but no objections from me.
| Style/StringMethods: | ||
| Enabled: true | ||
| GetText/DecorateFunctionMessage: | ||
| Enabled: false |
There was a problem hiding this comment.
we've disabled a bunch of stuff here? Are all these necessary? Definitely fine if it is, just wondering.
There was a problem hiding this comment.
PDK adds this file as-is by default. We aren't using it yet, though.
| GEM | ||
| remote: https://rubygems.org/ | ||
| specs: | ||
| addressable (2.7.0) |
There was a problem hiding this comment.
We should probably state somewhere what ruby, puppet version was used to generate the lock file; I guess we could call that the reference platform.
Like we discussed last time, there are so many combinations this was probably why it hadn't been included in the repo in the past.
There was a problem hiding this comment.
There is a default in the Gemfile that is used unless a specific version is given. This Gemfile.lock is generated from that default.
| api_key => $api_key, | ||
| hostname => $host, | ||
| service_name => $service_name, | ||
| service_name => $datadog_agent::params::service_name, |
Puppet Development Kit (PDK) is the recommended way to build and release Puppet modules. PDK adds a base set of files to the projects (think skel in the Unix world), which I've tried to respect and merge with the stuff we already had. Gem dependencies are now grouped under the meta-packages `puppet-module-*`, although unfortunately this is not available for Ruby 2.2 and earlier, where we still have to list dependencies manually. Also, these meta-packages don't work with unsupported combinations like Ruby 2.6 with Puppet < 6, so I had to remove those from the test matrix. I haven't enabled the rubocop check since it has lots of offenses, but will do so on a separate PR. Releases of the module can now be done using `pdk build`.
2 participants
Puppet Development Kit (PDK) is the recommended way to build and release Puppet modules.
PDK adds a base set of files to the projects (think skel in the Unix world), which I've tried to respect and merge with the stuff we already had.
Gem dependencies are now grouped under the meta-packages
puppet-module-*, although unfortunately this is not available for Ruby 2.2 and earlier, where we still have to list dependencies manually. Also, these meta-packages don't work with unsupported combinations like Ruby 2.6 with Puppet < 6, so I had to remove those from the test matrix.I haven't enabled the rubocop check since it has lots of offenses, but will do so on a separate PR.
Releases of the module can now be done using
pdk build.