Skip to content

Add additional parameters to http_check#599

Merged
albertvaka merged 3 commits intoDataDog:masterfrom
asenci:asenci/add_ssl_server_name_to_http_check
Jan 14, 2020
Merged

Add additional parameters to http_check#599
albertvaka merged 3 commits intoDataDog:masterfrom
asenci:asenci/add_ssl_server_name_to_http_check

Conversation

@asenci
Copy link
Copy Markdown
Contributor

@asenci asenci commented Jan 13, 2020

Add the check_hostname and ssl_server_name parameters
to the http_check integration

Add the check_hostname and ssl_server_name parameters
to the http_check integration
Copy link
Copy Markdown
Contributor

@albertvaka albertvaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch :) I left a couple minor comments.

Comment thread manifests/integrations/http_check.pp Outdated
Comment thread manifests/integrations/http_check.pp Outdated
@albertvaka
Copy link
Copy Markdown
Contributor

Looks good to me! Thanks again @asenci :)

@albertvaka albertvaka merged commit 0b24c8d into DataDog:master Jan 14, 2020
@albertvaka
Copy link
Copy Markdown
Contributor

This just went out in version 3.1.0.

@asenci asenci deleted the asenci/add_ssl_server_name_to_http_check branch January 14, 2020 21:09
cegeka-jenkins pushed a commit to cegeka/puppet-datadog_agent that referenced this pull request Apr 6, 2020
Add the check_hostname and ssl_server_name parameters
to the http_check integration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants