Add manage_dogapi_gem, making the management of ruby in reports optional#613
Merged
albertvaka merged 6 commits intomasterfrom Feb 20, 2020
Merged
Add manage_dogapi_gem, making the management of ruby in reports optional#613albertvaka merged 6 commits intomasterfrom
albertvaka merged 6 commits intomasterfrom
Conversation
albertvaka
force-pushed
the
albertvaka/manage-ruby
branch
from
bef05c8 to
e3fe421
Compare
albertvaka
force-pushed
the
albertvaka/manage-ruby
branch
from
e3fe421 to
d48efbc
Compare
KSerrania
reviewed
Feb 18, 2020
Comment on lines
+35
to
+36
| # $manage_ruby | ||
| # Invoke the ruby class to manage ruby install |
Contributor
There was a problem hiding this comment.
I agree that $manage_dogapi_gem seems more fitting for what this switch enables.
Member
There was a problem hiding this comment.
Agreed, the current name is a bit misleading.
truthbk
reviewed
Feb 18, 2020
Member
truthbk
left a comment
truthbk
left a comment
There was a problem hiding this comment.
I think the code changes are all sensible, I agree with perhaps using a different param name. Other than that 👌
albertvaka
changed the title
cegeka-jenkins
pushed a commit
to cegeka/puppet-datadog_agent
that referenced
this pull request
Apr 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebase of #227
Also included installing dogapi within the conditional. Since the code that we are making optional was there solely (if I understand correctly) to be able to install dogapi, it makes sense to me to treat it all together.
I'm not sure the name
manage_rubystill makes sense though, maybe something likemanage_dogapi_gemwould be better?