Conversation
mx-psi
force-pushed
the
mx-psi/puppet-install-info
branch
from
37a2c15 to
5b073e3
Compare
kbogtob
reviewed
May 29, 2020
kbogtob
reviewed
May 29, 2020
kbogtob
reviewed
May 29, 2020
| file { 'C:/ProgramData/Datadog/install_info': | ||
| owner => $dd_user, | ||
| group => $dd_group, | ||
| mode => '0660', |
Contributor
There was a problem hiding this comment.
Why different permissions? (640 or 660)
Member
Author
There was a problem hiding this comment.
I am not sure what the reason is for it but datadog.yaml has those permissions on Windows, so I guessed install_info should have the same. Should I change them on datadog.yaml too?
Member
Author
There was a problem hiding this comment.
Seems like it is used to give the administrator group access to the file (see #571)
kbogtob
reviewed
May 29, 2020
Contributor
kbogtob
left a comment
kbogtob
left a comment
There was a problem hiding this comment.
Good job! Left some comments
albertvaka
approved these changes
Jun 1, 2020
Contributor
albertvaka
left a comment
albertvaka
left a comment
There was a problem hiding this comment.
Looks good to me! Both the change and the test 🚀
cegeka-jenkins
pushed a commit
to cegeka/puppet-datadog_agent
that referenced
this pull request
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Creates
install_infofile with information about the install method used (overwrites any other existing file).Describe your test plan
I added some spec tests. Unfortunately in the test environment one can't get the puppet version, so that has to be tested manually:
pdk buildto create a .tar.gz of this versionsudo puppet module install <path to tar>install_infofile was created with correct content and permissions