Skip to content

Add trusted_facts_to_tags argument to add Agent tags from trusted facts#658

Merged
albertvaka merged 1 commit intomasterfrom
albertvaka/add-trusted_facts_to_tags
Oct 13, 2020
Merged

Add trusted_facts_to_tags argument to add Agent tags from trusted facts#658
albertvaka merged 1 commit intomasterfrom
albertvaka/add-trusted_facts_to_tags

Conversation

@albertvaka
Copy link
Copy Markdown
Contributor

What does this PR do?

Adds an argument trusted_facts_to_tags that behaves much like facts_to_tags but for trusted facts.

Note it's not possible to do the same for report tags (like with report_fact_tags), since there is no Puppet API to access trusted facts from outside Puppet code.

Motivation

Feature request.

@albertvaka albertvaka requested a review from a team as a code owner October 9, 2020 13:44
@albertvaka albertvaka force-pushed the albertvaka/add-trusted_facts_to_tags branch from 1f4ef8b to 1e89c5e Compare October 9, 2020 13:46
@albertvaka albertvaka changed the title Add trusted_facts_to_tags argument to tag by trusted facts Add trusted_facts_to_tags argument to add Agent tags by trusted facts Oct 9, 2020
@albertvaka albertvaka changed the title Add trusted_facts_to_tags argument to add Agent tags by trusted facts Add trusted_facts_to_tags argument to add Agent tags from trusted facts Oct 9, 2020
Note it's not possible to do the same for report tags, since there is
no Puppet API to access trusted facts from outside Puppet code.
@albertvaka albertvaka force-pushed the albertvaka/add-trusted_facts_to_tags branch from 1e89c5e to 8d2f9c7 Compare October 9, 2020 14:08
Copy link
Copy Markdown
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@albertvaka albertvaka merged commit bc43dac into master Oct 13, 2020
@albertvaka albertvaka deleted the albertvaka/add-trusted_facts_to_tags branch October 13, 2020 09:33
cegeka-jenkins pushed a commit to cegeka/puppet-datadog_agent that referenced this pull request Feb 5, 2026
Adds an argument trusted_facts_to_tags that behaves
much like facts_to_tags but for trusted facts.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants