Expose new parameters for disk check#679
Merged
mx-psi merged 5 commits intoDataDog:masterfrom Dec 29, 2020
Merged
Conversation
…roduced to the disk core integration
Aramack
changed the title
mx-psi
approved these changes
Dec 29, 2020
Member
mx-psi
left a comment
mx-psi
left a comment
There was a problem hiding this comment.
LGTM, thanks for your contribution!
cegeka-jenkins
pushed a commit
to cegeka/puppet-datadog_agent
that referenced
this pull request
Feb 5, 2026
* Expose the newly created _exclude and _include variable that were introduced to the disk core integration * Update disk comments * Unit tests for new module parameters * Whitespace
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This pull request exposes the new parameters for the disk check where whitelist/blacklist have been replaced with include/exclude: DataDog/integrations-core#7627
This does not modify the existing parameters to avoid introducing a regression.
Motivation
With the release of datadog-agent 7.24.0 (https://github.com/DataDog/integrations-core/blob/master/disk/CHANGELOG.md#400--2020-10-31--agent-7240), several parameters for the disk check were deprecated and replaced with new names.
As a result, continuing to use these variables will result in a deprecation warning such as:
2020-12-14 14:59:15 EST | CORE | WARN | (pkg/collector/python/datadog_agent.go:120 in LogMessage) | | (disk.py:95) |file_system_blacklistis deprecated and will be removed in a future release. Please usefile_system_excludeinstead.Describe your test plan
This includes a new unit test for the new parameters. I've also tested this on my personal puppet stack and confirmed that it generates a valid config: