Allow specifying an agent_flavor to install#686
Merged
albertvaka merged 8 commits intomasterfrom Feb 25, 2021
Merged
Conversation
mx-psi
approved these changes
Feb 24, 2021
Member
mx-psi
left a comment
mx-psi
left a comment
There was a problem hiding this comment.
LGTM!
I don't know if it's worth it but maybe we could check the agent_major_version to have a more descriptive error if someone tries to install IoT Agent version 6.x/5.x? Right now I am guessing they would just get a "pacakge not found" error which might be a bit confusing
mx-psi
reviewed
Feb 24, 2021
Contributor
Author
There are several settings that are not compatible with the iot-agent: configuring a python integration, configuring the system-probe, etc. I though about adding checks for those cases, but I think there are too many 😅 |
Co-authored-by: Pablo Baeyens <pablo.baeyens@datadoghq.com>
mx-psi
approved these changes
Feb 25, 2021
cegeka-jenkins
pushed a commit
to cegeka/puppet-datadog_agent
that referenced
this pull request
Feb 5, 2026
Make it possible to install the IoT flavor of the Agent. Caveats: - If the regular Agent is installed, it will fail to install the IoT Agent until the regular Agent is uninstalled (since the two packages install the same files). - Some settings aren't compatible with the IoT flavor of the Agent (major version < 7, python integrations, APM...)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Allow specifying an
agent_flavorto install.Motivation
Make it possible to install the IoT flavor of the Agent.
Additional notes
Caveats: If the regular Agent is installed, it will fail to install the IoT Agent until the regular Agent is uninstalled (since the two packages install the same files).