Require datadog_agent instead of including it#725
Merged
albertvaka merged 5 commits intomainfrom Jan 26, 2022
Merged
Conversation
mx-psi
approved these changes
Jan 26, 2022
Member
mx-psi
left a comment
mx-psi
left a comment
There was a problem hiding this comment.
LGTM. I am not sure about how big of a deal the breaking change is, but I trust your judgement 😄
cegeka-jenkins
pushed a commit
to cegeka/puppet-datadog_agent
that referenced
this pull request
Feb 5, 2026
Also fixes and expands the kitchen tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
require datadog_agentinstead ofinclude datadog_agent.Motivation
This ensures the right execution order of the classes.
Additional Notes
Supersedes #193
This is technically a breaking change, but I can't imagine a scenario where the old behaviour is useful.
Describe your test plan
Tests pass.