Skip to content

Allow Configuration of Puppet Reports URL#733

Merged
bkabrda merged 1 commit intoDataDog:mainfrom
ardichoke:reports_url_config
May 24, 2022
Merged

Allow Configuration of Puppet Reports URL#733
bkabrda merged 1 commit intoDataDog:mainfrom
ardichoke:reports_url_config

Conversation

@ardichoke
Copy link
Copy Markdown
Contributor

What does this PR do?

This allows for full configuration of what URL is used to ship puppet reports to datadog, while maintaining the current default configuration.

Motivation

At a site where I'm using this module, the puppetservers cannot access the Internet except by an nginx reverse proxy. In order to use this reverse proxy, I needed to patch the module to allow me to override the full URL, not just the site name with https://api. being hardcoded onto it.

@ardichoke ardichoke requested a review from a team as a code owner May 18, 2022 16:10
Copy link
Copy Markdown

@bkabrda bkabrda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'm merging this PR. Thanks a lot for the contribution!

@bkabrda bkabrda merged commit 0e1f469 into DataDog:main May 24, 2022
cegeka-jenkins pushed a commit to cegeka/puppet-datadog_agent that referenced this pull request Feb 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants