Skip to content

[cassandra, mysql] Add support for max_returned_metrics and dbm options#751

Merged
mx-psi merged 3 commits intoDataDog:mainfrom
rgergo:dbm
Oct 13, 2022
Merged

[cassandra, mysql] Add support for max_returned_metrics and dbm options#751
mx-psi merged 3 commits intoDataDog:mainfrom
rgergo:dbm

Conversation

@rgergo
Copy link
Copy Markdown
Contributor

@rgergo rgergo commented Sep 12, 2022

What does this PR do?

fix cassandra integration tags
add max_returned_metrics parameter for cassandra
add dbm paramter for mysql

Motivation

Additional Notes

Describe your test plan

@rgergo rgergo requested a review from a team as a code owner September 12, 2022 14:30
@rgergo rgergo force-pushed the dbm branch 3 times, most recently from f5e07bd to 9b588cf Compare September 22, 2022 14:50
@rgergo rgergo changed the title Add database monitoring flag to config Tagging and parameter fix and update Sep 22, 2022
Copy link
Copy Markdown
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Apologies for the delay. It looks like you will also need to modify the tests for these integrations so that CI passes. You can find the tests on the spec/classes folder

@rgergo
Copy link
Copy Markdown
Contributor Author

rgergo commented Oct 12, 2022

thank you for reviewing, and sorry its my first contribution to open source.
I corrected the test for cassandra.

@mx-psi mx-psi changed the title Tagging and parameter fix and update [cassandra, mysql] Add support for max_returned_metrics and dbm options Oct 13, 2022
Copy link
Copy Markdown
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution @rgergo! I will open a follow up PR rewording the docs a bit, but the functionality makes sense to me :)

@mx-psi mx-psi merged commit 0752342 into DataDog:main Oct 13, 2022
cegeka-jenkins pushed a commit to cegeka/puppet-datadog_agent that referenced this pull request Feb 5, 2026
…ns (DataDog#751)

* Add database monitoring flag to config

* tagging fix for yaml

* correcting cassandra test

Co-authored-by: Gergo Rozsa <gergo.rozsa@goto.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants