Mongo: Replace Deprecated Parameters#752
Conversation
PyMongo v3.9 and v3.12 Deprecated many ssl parameters in replace of tls counterparts. This was applied to the DataDog/integrations-core repository, but needed to be updated for pupper configs.
mx-psi
left a comment
mx-psi
left a comment
There was a problem hiding this comment.
👋 Apologies for the delay! The new TLS options look good to me, but we have to keep the SSL ones for backwards compatibility for existing users of the Puppet module.
Could you add the SSL options back? We can keep the sample usage section with only the TLS options, but the other two parts (options documentation and template) should still have the SSL options.
| # $ssl | ||
| # Optionally enable SSL for connection | ||
| # $ssl_ca_certs | ||
| # Optionally specify path to SSL Certificate Authority certificates | ||
| # $ssl_cert_reqs | ||
| # Optionally require SSL client certificate for connection | ||
| # $ssl_certfile | ||
| # Optionally specify path to SSL certificate for connection | ||
| # $ssl_keyfile | ||
| # Optionally specify path to SSL private key for connection |
There was a problem hiding this comment.
Please add these lines back: since the SSL options are still supported they should be documented
| @@ -11,19 +11,16 @@ instances: | |||
| - <%= tag %> | |||
There was a problem hiding this comment.
Please add all the SSL options back on the template too: since they are still supported this may break existing users of the Puppet module, so we should keep them here for now.
mx-psi
left a comment
mx-psi
left a comment
There was a problem hiding this comment.
That's perfect, thanks for addressing the comments :)
* Mongo: Replace Deprecated Parameters PyMongo v3.9 and v3.12 Deprecated many ssl parameters in replace of tls counterparts. This was applied to the DataDog/integrations-core repository, but needed to be updated for pupper configs. * Add support for older agents
2 participants
What does this PR do?
PyMongo v3.9 and v3.12 Deprecated many ssl parameters in replace of tls counterparts. This was applied to the DataDog/integrations-core repository, but needed to be updated for puppet configs.
Motivation
My DataDog Agent was having trouble running for MongoDB, and after some investigating found it to be due to the Puppet configuration using the older terms.
Additional Notes
For more information on the changes, see DataDog/integrations-core#12743 and https://pymongo.readthedocs.io/en/stable/changelog.html for v3.9 and v3.12
More of a personal note, I need to acknowledge @Mstrodl who pointed out that this issue was connected to the Puppet config! She really helped me find the root of the problem and get around to making these changes!
Describe your test plan
Run this config with an updated DataDog Agent