Document Windows NPM setup and make sure it starts#761
Merged
Conversation
buraizu
approved these changes
Nov 2, 2022
Contributor
buraizu
left a comment
buraizu
left a comment
There was a problem hiding this comment.
Approving, but left a small suggestion for consistency with other parameter descriptions
Co-authored-by: Bryce Eadie <bryce.eadie@datadoghq.com>
mx-psi
force-pushed
the
mx-psi/document-sysprobe-setup
branch
from
5e00d4f to
640f5ca
Compare
mx-psi
changed the title
KSerrania
reviewed
Nov 17, 2022
Contributor
KSerrania
left a comment
KSerrania
left a comment
There was a problem hiding this comment.
I've left some comments about the documentation, but otherwise this looks great!
mx-psi
commented
Nov 17, 2022
KSerrania
approved these changes
Nov 17, 2022
cegeka-jenkins
pushed a commit
to cegeka/puppet-datadog_agent
that referenced
this pull request
Feb 5, 2026
* Add documentation about Windows NPM setup * Apply suggestions from code review Co-authored-by: Bryce Eadie <bryce.eadie@datadoghq.com> * Add note about previous install * Notify services on system probe file updates * Restart the main Agent instead of the system probe * Apply suggestions from code review Co-authored-by: Bryce Eadie <bryce.eadie@datadoghq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
windows_npm_installwhen setting up NPM on Windows.Motivation
Additional Notes
It's difficult to do this automatically since we would have to call the
datadog::datadog_agentclass on thedatadog::system_probeone, so instead we are just documenting this.Describe your test plan
Docs only change.