Add support to run agent as domain user on Windows installation#785
Merged
KevinFairise2 merged 3 commits intomainfrom Aug 24, 2023
Merged
Add support to run agent as domain user on Windows installation#785KevinFairise2 merged 3 commits intomainfrom
KevinFairise2 merged 3 commits intomainfrom
Conversation
chouetz
approved these changes
Jul 17, 2023
| file { $dst_dir: | ||
| ensure => directory, | ||
| owner => $datadog_agent::params::dd_user, | ||
| owner => $datadog_agent::dd_user, |
Member
There was a problem hiding this comment.
Could we have set a different name not to confuse $datadog_agent::params::dd_user and $datadog_agent::dd_user?
Member
Author
There was a problem hiding this comment.
I think it is more explicit if they have the same name because params::dd_user is the default value for dd_user variable. Also those variables should never be edited by the user and are only internal variables.
julien-lebot
approved these changes
Aug 18, 2023
cegeka-jenkins
pushed a commit
to cegeka/puppet-datadog_agent
that referenced
this pull request
Feb 5, 2026
…Dog#785) * Add support to run agent as domain user on Windows installation * Update Puppet module to launch Agent as a domain user on windows * Update comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add options to run the agent as a domain user on Windows installation
Motivation
Should fix #742
Additional Notes
Describe your test plan