Parameter expansion#79
Closed
obowersa wants to merge 8 commits intoDataDog:masterfrom
Closed
Conversation
added 5 commits
March 31, 2015 15:09
Member
|
Nice work! We've queued some work on the puppet module, and try to figure out a solution to the problem you raised. We'll review that by then. |
|
Any info on when this will be merged? I've run in to a problem where I can't change the listen address, which is a PITA. |
Member
|
@ryandoherty I'm going to try to squeeze this into 1.7.0, I'm running some tests to make sure everything looks good. It's been a long time coming, our apologies for that. |
Member
|
Included in #176, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request to expand the current testing spec to cover paramaters in datadog.conf.erb in addition to expanding the parameters to cover (almost) all config options.
Not necessarily expecting this to get pulled but it's probably worth figuring out of this is a good approach to take.