Skip to content

Allow defining apm filter_tags to include or exclude traces#798

Merged
bkabrda merged 2 commits intoDataDog:mainfrom
erik-frontify:apm_allow_defining_filter_tags
Feb 19, 2024
Merged

Allow defining apm filter_tags to include or exclude traces#798
bkabrda merged 2 commits intoDataDog:mainfrom
erik-frontify:apm_allow_defining_filter_tags

Conversation

@erik-frontify
Copy link
Copy Markdown
Contributor

What does this PR do?

APM allows to filter traces / SPANs based on "filters" that can be configured in the datadog.yaml file
https://docs.datadoghq.com/tracing/guide/ignoring_apm_resources/?tab=datadogyaml#trace-agent-configuration-options

Motivation

We need to be able to configure that and the current module version doesn't allow us to do so.

Describe your test plan

If a value (hash) is set for "apm_filter_tags" (via hiera for example), the values will be merged into the datadog configuration hash / yaml file.

@erik-frontify erik-frontify marked this pull request as ready for review February 15, 2024 13:36
@erik-frontify erik-frontify requested a review from a team as a code owner February 15, 2024 13:36
@erik-frontify
Copy link
Copy Markdown
Contributor Author

We just successfully tested apm_filter_tags_regex in production...

Copy link
Copy Markdown

@bkabrda bkabrda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for sending the PR, I'm merging.

@bkabrda bkabrda merged commit 2765f3e into DataDog:main Feb 19, 2024
@erik-frontify erik-frontify deleted the apm_allow_defining_filter_tags branch February 20, 2024 08:00
cegeka-jenkins pushed a commit to cegeka/puppet-datadog_agent that referenced this pull request Feb 5, 2026
)

* Allow defining apm filter_tags to include or exclude traces based on filters

* Allow defining filter_tags_regex as well
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants