fix: do not set empty tls_protocols_allowed and tls_ciphers for es#852
Merged
fanny-jiang merged 3 commits intoDataDog:mainfrom Apr 3, 2025
Merged
Conversation
Contributor
Author
|
@fanny-jiang would you mind checking this? The elasticsearch integration is currently broken. Edit: i see the tests are failing, i will have a look. |
931eaba to
5fbb0bc
Compare
…assed via _instances Fix: Added fallback for possible empty params
5fbb0bc to
300195a
Compare
Contributor
Author
|
I fixed the issues from the test. I have also added some explicit checking for the tags param. Could you check the MR again? |
fanny-jiang
approved these changes
Apr 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR resolves an issue with the Elasticsearch integration, that prevented the integration from working when there are no values passed for
tls_protocols_allowedortls_ciphers.Motivation
When not passing any values for the
tls_protocols_allowedortls_ciphersthe following config is being generated:This result in the error below:
Additional Notes
Describe your test plan