Enable log collection for nginx integration#519
Merged
truthbk merged 6 commits intoDataDog:masterfrom May 14, 2019
jadams-av:jadams-av/enable-logs-nginx-integration
Merged
Enable log collection for nginx integration#519truthbk merged 6 commits intoDataDog:masterfrom jadams-av:jadams-av/enable-logs-nginx-integration
truthbk merged 6 commits intoDataDog:masterfrom
jadams-av:jadams-av/enable-logs-nginx-integration
Conversation
Add optional log collection to the nginx integration
dabcoder
reviewed
May 13, 2019
dabcoder
left a comment
dabcoder
left a comment
There was a problem hiding this comment.
Left some comments, thanks for working on this!
Rename service to match example code Add nginx error log to match example code
|
Thanks @jadams-av, will circle back with the team and update this thread as soon as possible. |
truthbk
reviewed
May 14, 2019
Member
truthbk
left a comment
truthbk
left a comment
There was a problem hiding this comment.
This is almost ready to go. Thanks for adding the spec test 🙇
truthbk
approved these changes
May 14, 2019
cegeka-jenkins
pushed a commit
to cegeka/puppet-datadog_agent
that referenced
this pull request
Apr 6, 2020
* Enable log collection for nginx integration Add optional log collection to the nginx integration * Fix value of path test * Update nginx_integration test Rename service to match example code Add nginx error log to match example code * Specify type of log variable * Fix data type syntax error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add optional log collection to the nginx integration