Weightage as u32

Author: Jouzo

lib/ain-dftx/src/types/mod.rs

@@ -26,7 +26,7 @@ use crate::custom_tx::CustomTxType;
 
 pub type Token = String;
 pub type Currency = String;
-pub type Weightage = u8;
+pub type Weightage = u32;
 
 #[derive(Debug, PartialEq, Eq)]
 pub enum DfTx {

lib/ain-dftx/src/types/oracles.rs

@@ -4,6 +4,7 @@ use bitcoin::{hash_types::Txid, io, ScriptBuf};
 use super::{
     common::CompactVec,
     price::{CurrencyPair, TokenPrice},
+    Weightage,
 };
 
 #[derive(ConsensusEncoding, Debug, PartialEq, Eq)]
@@ -21,14 +22,14 @@ pub struct RemoveOracle {
 #[derive(ConsensusEncoding, Debug, PartialEq, Eq)]
 pub struct AppointOracle {
     pub script: ScriptBuf,
-    pub weightage: u8,
+    pub weightage: Weightage,
     pub price_feeds: CompactVec<CurrencyPair>,
 }
 
 #[derive(ConsensusEncoding, Debug, PartialEq, Eq)]
 pub struct UpdateOracle {
     pub oracle_id: Txid,
     pub script: ScriptBuf,
-    pub weightage: u8,
+    pub weightage: Weightage,
     pub price_feeds: CompactVec<CurrencyPair>,
 }

lib/ain-ocean/src/indexer/oracle.rs

@@ -402,7 +402,7 @@ fn map_price_aggregated(
 
     let mut aggregated_total = Decimal::zero();
     let mut aggregated_count = 0;
-    let mut aggregated_weightage = 0u8;
+    let mut aggregated_weightage = 0;
 
     let oracles_len = oracles.len();
     for oracle in oracles {
@@ -424,12 +424,8 @@ fn map_price_aggregated(
         let time_diff = Decimal::from(feed.time) - Decimal::from(context.block.time);
         if Decimal::abs(&time_diff) < dec!(3600) {
             aggregated_count += 1;
-            aggregated_weightage =
-                aggregated_weightage
-                    .checked_add(oracle.weightage)
-                    .context(OtherSnafu {
-                        msg: "Error adding oracle weightage",
-                    })?;
+            aggregated_weightage += oracle.weightage;
+
             log::trace!(
                 "SetOracleData weightage: {:?} * oracle_price.amount: {:?}",
                 aggregated_weightage,
@@ -785,8 +781,8 @@ pub fn invalidate_oracle_interval(
         aggregated: OraclePriceAggregatedIntervalAggregated {
             amount: aggregated_amount.to_string(),
             weightage: aggregated_weightage
-                .to_u8()
-                .context(ToPrimitiveSnafu { msg: "to_u8" })?,
+                .to_u32()
+                .context(ToPrimitiveSnafu { msg: "to_u32" })?,
             count,
             oracles: OraclePriceAggregatedIntervalAggregatedOracles {
                 active: aggregated_active
@@ -847,8 +843,8 @@ fn forward_aggregate(
         aggregated: OraclePriceAggregatedIntervalAggregated {
             amount: aggregated_amount.to_string(),
             weightage: aggregated_weightage
-                .to_u8()
-                .context(ToPrimitiveSnafu { msg: "to_u8" })?,
+                .to_u32()
+                .context(ToPrimitiveSnafu { msg: "to_u32" })?,
             count,
             oracles: OraclePriceAggregatedIntervalAggregatedOracles {
                 active: aggregated_active